| Date | Tue, 11 May 2010 08:10:49 -0700 | From | Greg KH <> | Subject | Re: [107/117] ACPI: DMI init_set_sci_en_on_resume for multiple Lenovo ThinkPads |
| |
On Mon, May 10, 2010 at 09:38:25PM -0600, Alex Chiang wrote: > Hm, this patch looks a little wonky. > > Why is every entry repeated 3x? > > > + .callback = init_set_sci_en_on_resume, > > + .ident = "Lenovo ThinkPad T410", > > [snip] > > > + .callback = init_set_sci_en_on_resume, > > + .ident = "Lenovo ThinkPad T410", > > [snip[ > > > + .callback = init_set_sci_en_on_resume, > > + .ident = "Lenovo ThinkPad T410", > > Oh crap, it's broken upstream too. :( > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=patch;h=07bedca29b0973f36a6b6db36936deed367164ed > > Not sure what happened, but I think some sort of hiccup occurred > when the patch was applied, since this is what hit the mailing > lists: > > https://patchwork.kernel.org/patch/94711/ > > Len, Greg, what would you like me to do? I think the cleanest > thing to do to help keep -stable clean would be to: > > a) drop this patch from current -stable queue > b) revert 07bedca29b09 upstream > c) apply the patch from patchwork > d) re-apply to -stable > > Thoughts?
How about getting a fixup patch into Linus's tree and then I'll apply that fixup patch to stable as well?
In the meantime, triplicates don't hurt anyone :)
thanks,
greg k-h
|