Messages in this thread |  | | | Date | Tue, 11 May 2010 03:54:19 -0500 | | From | "Serge E. Hallyn" <> | | Subject | Re: [PATCH 4/4] INIT_SIGHAND: use SIG_DFL instead of NULL |
| |
Quoting Oleg Nesterov (oleg@redhat.com): > Cosmetic, no changes in the compiled code. Just s/NULL/SIG_DFL/ to make > it more readable and grep-friendly. > > Note: probably SIG_IGN makes more sense, we could kill ignore_signals(). > But then kernel_init() should do flush_signal_handlers() before exec(). > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Serge E. Hallyn <serue@us.ibm.com>
> --- > > include/linux/init_task.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- 34-rc1/include/linux/init_task.h~4_INIT_SIGHAND_USE_SIG_DFL 2010-05-10 20:26:08.000000000 +0200 > +++ 34-rc1/include/linux/init_task.h 2010-05-10 21:06:03.000000000 +0200 > @@ -43,7 +43,7 @@ extern struct nsproxy init_nsproxy; > > #define INIT_SIGHAND(sighand) { \ > .count = ATOMIC_INIT(1), \ > - .action = { { { .sa_handler = NULL, } }, }, \ > + .action = { { { .sa_handler = SIG_DFL, } }, }, \ > .siglock = __SPIN_LOCK_UNLOCKED(sighand.siglock), \ > .signalfd_wqh = __WAIT_QUEUE_HEAD_INITIALIZER(sighand.signalfd_wqh), \ > }
|  |