lkml.org 
[lkml]   [2010]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch]hp_accel: Fix race in device removal
Date
Am Dienstag, 11. Mai 2010 04:57:25 schrieb Andrew Morton:
> On Tue, 11 May 2010 07:55:07 +0200 Oliver Neukum <oneukum@suse.de> wrote:
>
> > Am Dienstag, 11. Mai 2010 00:46:32 schrieb Andrew Morton:
> > > But alas, I (and presumably others) cannot confirm that, because you
> > > didn't describe the bug :( This also means that if someone hits a
> > > problem with this driver, they won't easily be able to work out whether
> > > this patch will fix it.
> > >
> > >
> > > Under what circumstances does it trigger?
> > >
> > > What are the observed effects when it triggers?
> > >
> > > Please always include this sort of information when sending bugfixes, thanks.
> >
> > Sorry,
> >
> > the patch closes a window during which a work queue might remain
> > active after the device is removed and would then lead to ACPI calls
> > with undefined behavior.
>
> Had anyone observed this in the field? Was a machine crashing, perhaps?

No, this was found during a code review.

Regards
Oliver


\
 
 \ /
  Last update: 2010-05-12 10:35    [W:0.049 / U:1.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site