Messages in this thread | | | Subject | Re: [PATCH 1/2 V3] hwmon: (coretemp) Detect the thermal sensors by CPUID | From | Valdis.Kletnieks@vt ... | Date | Tue, 11 May 2010 17:45:19 -0400 |
| |
On Tue, 11 May 2010 16:01:12 +0800, Huaxu Wan said: > The thermal sensors of Intel(R) CPUs can be detected by CPUID instruction, > indicated by CPUID.06H.EAX[0]. > > Signed-off-by: Huaxu Wan <huaxu.wan@linux.intel.com> > Signed-off-by: Carsten Emde <C.Emde@osadl.org> > --- > drivers/hwmon/coretemp.c | 34 +++++++++++++--------------------- > 1 files changed, 13 insertions(+), 21 deletions(-) > > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c > index e9b7fbc..be0ddcf 100644 > --- a/drivers/hwmon/coretemp.c > +++ b/drivers/hwmon/coretemp.c > @@ -451,28 +451,20 @@ static int __init coretemp_init(void) > > for_each_online_cpu(i) { > struct cpuinfo_x86 *c = &cpu_data(i); > + /* > + * CPUID.06H.EAX[0] indicates whether the CPU has thermal > + * sensors. We check this bit only, all the early CPUs > + * without thermal sensors will be filtered out. > + */ > + if (c->cpuid_level >= 6 && (cpuid_eax(0x06) & 0x01)) { > + err = coretemp_device_add(i); > + if (err) > + goto exit_devices_unreg;
OK, that looks sane. :) For what it's worth, feel free to stick on a
Reviewed-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> [unhandled content-type:application/pgp-signature] | |