Messages in this thread | | | Date | Tue, 11 May 2010 20:28:16 +0200 | From | Albert Herranz <> | Subject | Re: [PATCH 5/6] swiotlb: Make swiotlb bookkeeping functions visible in the header file. |
| |
Konrad Rzeszutek Wilk wrote: > We put the functions dealing with the operations on > the SWIOTLB buffer in the header and make those functions non-static. > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > --- > include/linux/swiotlb.h | 22 ++++++++++++++++++++++ > lib/swiotlb.c | 28 ++++++++++++---------------- > 2 files changed, 34 insertions(+), 16 deletions(-) > > diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h > index f3fc331..dabfd0b 100644 > --- a/include/linux/swiotlb.h > +++ b/include/linux/swiotlb.h > @@ -25,6 +25,28 @@ extern int swiotlb_force; > extern void swiotlb_init(int verbose); > extern void swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose); > > +/* > + * Enumeration for sync targets > + */ > +enum dma_sync_target { > + SYNC_FOR_CPU = 0, > + SYNC_FOR_DEVICE = 1, > +}; > +extern void *swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t phys, > + u64 tbl_dma_addr, size_t size, > + enum dma_data_direction dir); > +
The phys and tbl_dma_addr arguments in the function prototype are swapped compared to the function definition in patch 1/6.
Cheers, Albert
| |