lkml.org 
[lkml]   [2010]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip 1/5] [CLEANUP] kprobes: Remove redundant text_mutex lock in optimize
Hi Mathieu,

Mathieu Desnoyers wrote:
> * Masami Hiramatsu (mhiramat@redhat.com) wrote:
>> Remove text_mutex locking in optimize_all_kprobes, because
>> that function doesn't modify text but just order optimization
>> to worker.
>
> Hi Masami,
>
> A few comments:
>
> 1) optimize_all_kprobes/unoptimize_all_kprobes should have comments saying that
> they are always called with kprobe_mutex held.
>
> 2) The sentence above in the changelog could be changed into:
>
> ..."because this function doesn't modify text. It simply queues optimizations
> for the kprobe_optimizer worker thread."
>
> 3)
>
> static DEFINE_MUTEX(kprobe_mutex); /* Protects kprobe_table */
>
> .. should also state that it protects optimizing_list.
>

Thanks! all comments are good to me!

Thank you again,




--
Masami Hiramatsu
e-mail: mhiramat@redhat.com



\
 
 \ /
  Last update: 2010-05-12 10:15    [W:0.057 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site