| | Date | Mon, 10 May 2010 13:54:17 -0700 | | From | Dmitry Torokhov <> | | Subject | Re: [PATCH v3] ad7877: keep dma rx buffers in seperate cache lines |
| |
On Mon, May 10, 2010 at 12:39:49PM -0400, Mike Frysinger wrote: > On Mon, May 10, 2010 at 06:42, Oskar Schirmer wrote: > > With dma based spi transmission, data corruption > > is observed occasionally. With dma buffers located > > right next to msg and xfer fields, cache lines > > correctly flushed in preparation for dma usage > > may be polluted again when writing to fields > > in the same cache line. > > > > Make sure cache fields used with dma do not > > share cache lines with fields changed during > > dma handling. As both fields are part of a > > struct that is allocated via kzalloc, thus > > cache aligned, moving the fields to the 1st > > position and insert padding for alignment > > does the job. > > Acked-by: Mike Frysinger <vapier@gentoo.org> > > i'm guessing Dmitry will pick it up now
Yep.
-- Dmitry
|