lkml.org 
[lkml]   [2010]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[012/117] flex_array: fix the panic when calling flex_array_alloc() without __GFP_ZERO
    2.6.33-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Changli Gao <xiaosuo@gmail.com>

    commit e59464c735db19619cde2aa331609adb02005f5b upstream.

    memset() is called with the wrong address and the kernel panics.

    Signed-off-by: Changli Gao <xiaosuo@gmail.com>
    Cc: Patrick McHardy <kaber@trash.net>
    Acked-by: David Rientjes <rientjes@google.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    lib/flex_array.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/lib/flex_array.c
    +++ b/lib/flex_array.c
    @@ -99,7 +99,7 @@ struct flex_array *flex_array_alloc(int
    ret->element_size = element_size;
    ret->total_nr_elements = total;
    if (elements_fit_in_base(ret) && !(flags & __GFP_ZERO))
    - memset(ret->parts[0], FLEX_ARRAY_FREE,
    + memset(&ret->parts[0], FLEX_ARRAY_FREE,
    FLEX_ARRAY_BASE_BYTES_LEFT);
    return ret;
    }



    \
     
     \ /
      Last update: 2010-05-12 11:27    [W:0.019 / U:58.408 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site