lkml.org 
[lkml]   [2010]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/10] perf/trace/scripting: failed-syscalls script cleanup
    Date
    From: Tom Zanussi <tzanussi@gmail.com>

    A couple small fixes for the failed syscalls script:

    - The script description says it can be restricted to a specific comm,
    make it so.

    - silence the match output in the shell script

    Cc: Frédéric Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    LKML-Reference: <1273466820-9330-2-git-send-email-tzanussi@gmail.com>
    Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/scripts/perl/bin/failed-syscalls-report | 2 +-
    tools/perf/scripts/perl/failed-syscalls.pl | 6 +++++-
    2 files changed, 6 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/scripts/perl/bin/failed-syscalls-report b/tools/perf/scripts/perl/bin/failed-syscalls-report
    index f634608..e3a5e55 100644
    --- a/tools/perf/scripts/perl/bin/failed-syscalls-report
    +++ b/tools/perf/scripts/perl/bin/failed-syscalls-report
    @@ -2,7 +2,7 @@
    # description: system-wide failed syscalls
    # args: [comm]
    if [ $# -gt 0 ] ; then
    - if ! expr match "$1" "-" ; then
    + if ! expr match "$1" "-" > /dev/null ; then
    comm=$1
    shift
    fi
    diff --git a/tools/perf/scripts/perl/failed-syscalls.pl b/tools/perf/scripts/perl/failed-syscalls.pl
    index c18e7e2..94bc25a 100644
    --- a/tools/perf/scripts/perl/failed-syscalls.pl
    +++ b/tools/perf/scripts/perl/failed-syscalls.pl
    @@ -11,6 +11,8 @@ use Perf::Trace::Core;
    use Perf::Trace::Context;
    use Perf::Trace::Util;

    +my $for_comm = shift;
    +
    my %failed_syscalls;

    sub raw_syscalls::sys_exit
    @@ -33,6 +35,8 @@ sub trace_end

    foreach my $comm (sort {$failed_syscalls{$b} <=> $failed_syscalls{$a}}
    keys %failed_syscalls) {
    - printf("%-20s %10s\n", $comm, $failed_syscalls{$comm});
    + next if ($for_comm && $comm ne $for_comm);
    +
    + printf("%-20s %10s\n", $comm, $failed_syscalls{$comm});
    }
    }
    --
    1.6.2.5
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-05-12 10:35    [W:0.043 / U:1.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site