lkml.org 
[lkml]   [2010]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/8] x86/mrst: add vrtc driver which serves as a wall clock device
    On Tue, 11 May 2010 02:22:15 +0800
    "H. Peter Anvin" <hpa@zytor.com> wrote:

    > On 05/10/2010 02:17 AM, Feng Tang wrote:
    > >
    > > Thank you all for the comments. please review this follow-on patch.
    > >
    > > - Feng
    >
    > That doesn't move it to common code, though. I'd rather see existing
    > common style used, then merged (centralized) and *then* the style
    > corrected.
    >
    > -hpa

    Hi Peter,

    The reason I didn't move it to rtc common code is, this vrtc.c sits in
    arch/x86/kernel/ and better not to depend on drivers/rtc, as drivers/rtc
    may not be always enabled in kernel configuration.

    I also have another general driver for vrtc which will be in drivers/rtc/,
    just like general x86 kernel which has a rtc.c in arch/ and a rtc-cmos.c
    in drivers/rtc, I will clean my code up and try to move these funcs to a
    common code.

    Thanks,
    Feng


    \
     
     \ /
      Last update: 2010-05-12 10:17    [W:0.021 / U:0.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site