lkml.org 
[lkml]   [2010]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] swiotlb: Make swiotlb bookkeeping functions visible in the header file.
> > +extern void swiotlb_full(struct device *dev, size_t size,
> > + enum dma_data_direction dir, int do_panic);
> > +
>
> Please don't. You create a new IOMMU implementation with the helper
> function. We don't want another IOMMU implementation that has broken
> 'overflow buffer' concept.

Of course. Will remove that. Thanks again for your review, much
appreciated.

>
> swiotlb-xen should handle DMA mapping errors properly instead of
> calling swiotlb_full().

<nods>
>
> btw, if you try to push xen swiotlb stuff to mainline, please don't
> put xen swiotlb stuff to include/linux/swiotlb.h.

OK.


\
 
 \ /
  Last update: 2010-05-12 10:15    [W:0.051 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site