Messages in this thread | | | Date | Mon, 10 May 2010 15:35:31 -0400 | From | Konrad Rzeszutek Wilk <> | Subject | Re: [PATCH 5/6] swiotlb: Make swiotlb bookkeeping functions visible in the header file. |
| |
> > +extern void swiotlb_full(struct device *dev, size_t size, > > + enum dma_data_direction dir, int do_panic); > > + > > Please don't. You create a new IOMMU implementation with the helper > function. We don't want another IOMMU implementation that has broken > 'overflow buffer' concept.
Of course. Will remove that. Thanks again for your review, much appreciated.
> > swiotlb-xen should handle DMA mapping errors properly instead of > calling swiotlb_full().
<nods> > > btw, if you try to push xen swiotlb stuff to mainline, please don't > put xen swiotlb stuff to include/linux/swiotlb.h.
OK.
| |