lkml.org 
[lkml]   [2010]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[09/98] mac80211: remove bogus TX agg state assignment
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Johannes Berg <johannes@sipsolutions.net>

    commit b4bb5c3fd9333024044362df67e23e96158489ed upstream.

    When the addba timer expires but has no work to do,
    it should not affect the state machine. If it does,
    TX will not see the successfully established and we
    can also crash trying to re-establish the session.

    Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/mac80211/agg-tx.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/net/mac80211/agg-tx.c
    +++ b/net/mac80211/agg-tx.c
    @@ -181,7 +181,6 @@ static void sta_addba_resp_timer_expired
    HT_AGG_STATE_REQ_STOP_BA_MSK)) !=
    HT_ADDBA_REQUESTED_MSK) {
    spin_unlock_bh(&sta->lock);
    - *state = HT_AGG_STATE_IDLE;
    #ifdef CONFIG_MAC80211_HT_DEBUG
    printk(KERN_DEBUG "timer expired on tid %d but we are not "
    "(or no longer) expecting addBA response there",



    \
     
     \ /
      Last update: 2010-05-12 10:11    [W:4.068 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site