Messages in this thread | | | Date | Tue, 11 May 2010 08:08:27 +1000 | From | Nigel Cunningham <> | Subject | Re: [PATCH] Check kmalloc return value before use the buffer |
| |
Hi.
On 11/05/10 07:49, Andy Isaacson wrote: > On Fri, May 07, 2010 at 03:17:39PM +0800, Steven Liu wrote: >> bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL); >> + if (bigrxbuf_virtual == NULL) { >> + status = -ENOMEM; >> + kfree(bigtxbuf_virtual); >> + goto out; >> + } > > On Sat, May 08, 2010 at 11:27:09AM +1000, Nigel Cunningham wrote: >>> Acked-by: Linus Walleij<linus.walleij@stericsson.com> >> >> Acked-by: Nigel Cunningham<nigel@tuxonice.net> > > NACK. Don't duplicate kfree(), instead do something like
Yeah... that is a better way of doing it.
Regards,
Nigel
| |