lkml.org 
[lkml]   [2010]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/10] perf/trace/scripting: wakeup-latency script cleanup
    Date
    From: Tom Zanussi <tzanussi@gmail.com>

    Some minor fixes for the wakeup-latency script:

    - Fix nuisance 'use of uninitialized value' warnings

    - Avoid divide-by-zero error

    Cc: Frédéric Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    LKML-Reference: <1273466820-9330-5-git-send-email-tzanussi@gmail.com>
    Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/scripts/perl/wakeup-latency.pl | 12 ++++++++----
    1 files changed, 8 insertions(+), 4 deletions(-)

    diff --git a/tools/perf/scripts/perl/wakeup-latency.pl b/tools/perf/scripts/perl/wakeup-latency.pl
    index ed58ef2..d9143dc 100644
    --- a/tools/perf/scripts/perl/wakeup-latency.pl
    +++ b/tools/perf/scripts/perl/wakeup-latency.pl
    @@ -22,8 +22,8 @@ my %last_wakeup;

    my $max_wakeup_latency;
    my $min_wakeup_latency;
    -my $total_wakeup_latency;
    -my $total_wakeups;
    +my $total_wakeup_latency = 0;
    +my $total_wakeups = 0;

    sub sched::sched_switch
    {
    @@ -67,8 +67,12 @@ sub trace_end
    {
    printf("wakeup_latency stats:\n\n");
    print "total_wakeups: $total_wakeups\n";
    - printf("avg_wakeup_latency (ns): %u\n",
    - avg($total_wakeup_latency, $total_wakeups));
    + if ($total_wakeups) {
    + printf("avg_wakeup_latency (ns): %u\n",
    + avg($total_wakeup_latency, $total_wakeups));
    + } else {
    + printf("avg_wakeup_latency (ns): N/A\n");
    + }
    printf("min_wakeup_latency (ns): %u\n", $min_wakeup_latency);
    printf("max_wakeup_latency (ns): %u\n", $max_wakeup_latency);

    --
    1.6.2.5
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-05-12 10:09    [W:0.038 / U:0.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site