Messages in this thread |  | | | Date | Mon, 10 May 2010 08:31:13 -0700 | | From | Charles Clément <> | | Subject | Re: [PATCH] Staging: comedi: Fix long line lengths in comedi_fops.c |
| |
Hello Mark,
On Mon, May 10, 2010 at 05:36:57PM +0800, Mark wrote: > This patch fixes lots of long line lengths in comedi_fops.c found by > checkpatch.pl > > Signed-off-by: Mark Rankilor <reodge@gmail.com> > --- > drivers/staging/comedi/comedi_fops.c | 38 ++++++++++++++++++++++----------- > 1 files changed, 25 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c > index e7095d7..9bfab73 100644 > --- a/drivers/staging/comedi/comedi_fops.c > +++ b/drivers/staging/comedi/comedi_fops.c > @@ -962,7 +962,8 @@ static int do_insn_ioctl(struct comedi_device *dev, > if (ret < 0) > goto error; > if (insn.insn & INSN_MASK_READ) { > - if (copy_to_user(insn.data, data, insn.n * sizeof(unsigned int))) { > + if (copy_to_user > + (insn.data, data, insn.n * sizeof(unsigned int))) {
I think it'd be better to keep the opening parenthesis on the same line of the function and maybe the first argument, too.
> > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
-- Charles Clément
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |