Messages in this thread |  | | | Date | Mon, 10 May 2010 14:43:53 +0200 | | From | Robert Richter <> | | Subject | Re: [patch 1/4] x86,perf: P4 PMU -- configurate predefined events |
| |
On 08.05.10 07:25:51, Cyrill Gorcunov wrote: > If an event is not RAW we should exit p4_hw_config > early but call x86_setup_perfctr as well. > > CC: Peter Zijlstra <peterz@infradead.org> > CC: Ingo Molnar <mingo@elte.hu> > CC: Frederic Weisbecker <fweisbec@gmail.com> > CC: Lin Ming <ming.m.lin@intel.com> > CC: Robert Richter <robert.richter@amd.com> > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> > --- > > Robert, if only I'm not missing something this is > a side effect of commit 9d0fcba67e47ff398a6fa86476d4884d472dc98a, > wonders why don't we hit it earlier. Am I wrong?
Yes, that's true, the function had have two exit points. Thanks for the fix.
-Robert
-- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@amd.com
|  |