Messages in this thread | | | Date | Fri, 9 Apr 2010 10:50:23 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA |
| |
On Fri, 9 Apr 2010, Borislav Petkov wrote: > > From: Linus Torvalds <torvalds@linux-foundation.org> > Date: Fri, Apr 09, 2010 at 09:35:15AM -0700 > > > Can you try with _just_ my patch? > > Yep, yours along with the SLUB debugging piece just survived one > hibernation cycle without a problem. Also, no SIGBUS-killed processes, > all seems fine. Will continue stressing it though... > > Let me know what you want me to do next.
Continue stress-testing it. I don't think my patch on its own should fix the original problem, but at least we now know why you got those NULL anon_vma's.
So what I _think_ will happen is that you'll be able to re-create the problem that started this all. But I'd like to verify that, just because I'm anal and I'd like these things to be tested independently.
So assuming that the original problem happens again, if you can then apply Rik's patch, but add a
dst->anon_vma = src->anon_vma;
to just before the success case (the "return 0") in anon_vma_clone(), that would be good.
Linus
| |