lkml.org 
[lkml]   [2010]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH] perf_events: fix bogus warn_on(_once) in perf_prepare_sample()
	There is a warn_on_once() check for PERF_SAMPLE_RAW which trips
when using PEBS on both Core and Nehalem. Core PEBS sample size is 144
bytes and 176 bytes for Nehalem. Both are multiples of 8, but the size
field is encoded as int, thus the total is never a multiple of 8 which
trips the check. I think the size should have been u64, but now it is
too late to change given it is ABI.

Signed-off-by: Stephane Eranian <eranian@google.com>

diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index 8143e77..fffeb95 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -3311,7 +3311,6 @@ void perf_prepare_sample(struct perf_event_header *header,
else
size += sizeof(u32);

- WARN_ON_ONCE(size & (sizeof(u64)-1));
header->size += size;
}


\
 
 \ /
  Last update: 2010-04-08 22:53    [W:0.058 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site