lkml.org 
[lkml]   [2010]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] scheduler fix

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

>
>
> On Thu, 8 Apr 2010, Ingo Molnar wrote:
> >
> > So i'd suggest changing nr_cpu_ids to unsigned int [unless there's some strong
> > reason to have it signed] plus doing something like:
> >
> > if (len < (nr_cpu_ids >> BITS_PER_BYTE_BITS))
>
> No workee.
>
> It really should round up.

Indeed.

> If you worry about code generation, I'd suggest looking at whether
> nr_cpu_ids could just be made unsigned.
>
> Anyway, this all was _not_ the point of my original email. I really don't
> care about this particular instance. I care more about the whole "in general
> people should think _way_ more about validating user-supplied arguments than
> clearly happened this time".

Yeah, no argument about that, point taken and accepted.

Ingo


\
 
 \ /
  Last update: 2010-04-08 20:55    [from the cache]
©2003-2011 Jasper Spaans