Messages in this thread | | | Date | Thu, 8 Apr 2010 11:32:06 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeable VMA |
| |
On Thu, 8 Apr 2010, Rik van Riel wrote: > > Reviewed-by: Rik van Riel <riel@redhat.com>
Yeah, I think I'll commit it as-is, assuming we get confirmation that it (along with your patch) actually ends up fixing the original problem.
I had actually had lockdep etc on with that patch, but for some reason I'd overlooked the SPINLOCK_SLEEP debugging, so I hadn't seen the stupid issue that Borislav pointed out. I wonder if LOCKDEP or spinlock debugging hould just select it. Small detail, but I should have caught that obvious bug myself.
> I haven't seen any places that insert VMAs by itself. > Several strange places that allocate them, but they > all appear to use the standard functions to insert them.
Yeah, it's complicated enough to add a vma with all the rbtree etc stuff that I hope nobody actually cooks their own. But I too grepped for vma allocations, and there were more of them than I expected, so...
Linus
| |