lkml.org 
[lkml]   [2010]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch,rfc v2] ext3/4: enhance fsync performance when using cfq
On Thu, Apr 08 2010, Jeff Moyer wrote:
> Vivek Goyal <vgoyal@redhat.com> writes:
>
> > On Thu, Apr 08, 2010 at 01:00:45PM +0200, Jens Axboe wrote:
>
> >> I like the concept, it's definitely useful (and your results amply
> >> demonstrate that). I was thinking if there was a way in through the ioc
> >> itself, rather than bdi -> queue and like you are doing. But I can't
> >> think of a nice way to do it, so this is probably as good as it gets.
> >>
> >
> > I think, one issue with ioc based approach will be that it will then call
> > yield operation on all the devices in the system where this context has ever
> > done any IO. With bdi based approach this call will remain limited to
> > a smaller set of devices.
>
> Which actually brings up the question of whether this needs some
> knowledge of whether the journal is on the same device as the file
> system! In such a case, we need not yield. I think I'll stick my head
> in the sand for this one. ;-)

Yes, that is true. But that should be relatively easy to check.

--
Jens Axboe



\
 
 \ /
  Last update: 2010-04-08 16:09    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site