Messages in this thread Patch in this message | | | Date | Wed, 7 Apr 2010 09:59:10 -0400 | From | Jeff Dike <> | Subject | Re: [PATCH] Fix vq_memory_access_ok error checking |
| |
On Wed, Apr 07, 2010 at 10:49:07AM +0300, Michael S. Tsirkin wrote: > Thanks! > Can you add a Signed-off-by line?
Oops, I was in a hurry...
commit 7938779d9f357ede8bc3c122fd0dc9d5ec4fcf1d Author: Jeff Dike <jdike@addtoit.com> Date: Wed Mar 31 15:05:08 2010 -0400
vq_memory_access_ok needs to check whether mem == NULL
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 7bd7a1e..b8e1127 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -235,6 +235,10 @@ static int vq_memory_access_ok(void __user *log_base, struct vhost_memory *mem, int log_all) { int i; + + if (!mem) + return 0; + for (i = 0; i < mem->nregions; ++i) { struct vhost_memory_region *m = mem->regions + i; unsigned long a = m->userspace_addr;
| |