Messages in this thread | | | Subject | Re: [patch 1/3] kernel: local_irq_{save,restore}_nmi() | From | Steven Rostedt <> | Date | Tue, 06 Apr 2010 21:13:10 -0400 |
| |
On Tue, 2010-04-06 at 15:28 +0200, Peter Zijlstra wrote:
> Index: linux-2.6/kernel/trace/trace_irqsoff.c > =================================================================== > --- linux-2.6.orig/kernel/trace/trace_irqsoff.c > +++ linux-2.6/kernel/trace/trace_irqsoff.c > @@ -316,6 +316,14 @@ void trace_hardirqs_off(void) > } > EXPORT_SYMBOL(trace_hardirqs_off); > > +void trace_hardirqs_off_no_nmi(void) > +{ > + WARN_ON_ONCE(in_nmi());
Should we do this for all archs? I can imagine a lot of warning reports coming in the near future. And they will be passing it towards me.
-- Steve
> + if (!preempt_trace() && irq_trace()) > + start_critical_timing(CALLER_ADDR0, CALLER_ADDR1); > +} > +EXPORT_SYMBOL(trace_hardirqs_off_no_nmi); > + > void trace_hardirqs_on_caller(unsigned long caller_addr) > { > if (!preempt_trace() && irq_trace()) > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |