Messages in this thread | | | Date | Tue, 6 Apr 2010 15:48:31 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH] proc: pagemap: Hold mmap_sem during page walk |
| |
On Fri, 2 Apr 2010 09:30:58 -0500 Matt Mackall <mpm@selenic.com> wrote:
> On Fri, Apr 02, 2010 at 09:11:29AM +0900, KAMEZAWA Hiroyuki wrote: > > > int ret = -ESRCH; > ... > > + pm.len = PM_ENTRY_BYTES * (PAGEMAP_WALK_SIZE >> PAGE_SHIFT); > > + pm.buffer = kmalloc(pm.len, GFP_TEMPORARY); > > + if (!pm.buffer) > > goto out_mm; > ... > > out_mm: > > mmput(mm); > > Looks like this gets the wrong return code? > I'm sorry. And thank you for pointing out. I confirmed merged one has fixed code.
Regards, -Kame
| |