lkml.org 
[lkml]   [2010]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH -v2] rmap: fix anon_vma_fork() memory leak
    Fix a memory leak in anon_vma_fork(), where we fail to tear down the
    anon_vmas attached to the new VMA in case setting up the new anon_vma
    fails.

    This bug also has the potential to leave behind anon_vma_chain structs
    with pointers to invalid memory.

    Reported-by: Minchan Kim <minchan.kim@gmail.com>
    Signed-off-by: Rik van Riel <riel@redhat.com>

    diff --git a/mm/rmap.c b/mm/rmap.c
    index fcd593c..eaa7a09 100644
    --- a/mm/rmap.c
    +++ b/mm/rmap.c
    @@ -232,6 +232,7 @@ int anon_vma_fork(struct vm_area_struct *vma, struct vm_area_struct *pvma)
    out_error_free_anon_vma:
    anon_vma_free(anon_vma);
    out_error:
    + unlink_anon_vmas(vma);
    return -ENOMEM;
    }


    \
     
     \ /
      Last update: 2010-04-05 18:17    [W:0.018 / U:30.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site