Messages in this thread | | | Date | Mon, 5 Apr 2010 16:09:09 +0200 | From | Joerg Roedel <> | Subject | Re: [patch] dma-debug: off by one issue |
| |
On Mon, Apr 05, 2010 at 04:02:15PM +0200, Joerg Roedel wrote: > On Mon, Apr 05, 2010 at 03:53:30PM +0300, Dan Carpenter wrote: > > On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote: > > > > The character is already reserved by the user-to-kernel copy earlier in > > > the function. > > > > Yes, but the original code requires more code reading to audit. Let's > > change the commit message to say that it's a clean up patch. > > In this case its better to remove the > > current_driver_name[i] = 0; > > line just after the loop.
Ah no, thats nonsense. Mind to resend the patch with a new commit-message? I'll queue it then tomorrow.
Joerg
| |