lkml.org 
[lkml]   [2010]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch v2] acpi_pad: "processor_aggregator" name too long
    On Thu, Mar 25, 2010 at 10:41:22PM +0800, Dan Carpenter wrote:
    > cpi_device_class can only be 19 characters and a NULL terminator.
    >
    > With the current name we get a buffer overflow in acpi_pad_add()
    > strcpy(acpi_device_class(device), ACPI_PROCESSOR_AGGREGATOR_CLASS);
    >
    > Signed-off-by: Dan Carpenter <error27@gmail.com>
    > ---
    > V2: Thanks to Pavel Machek for coming up with the right name for this.
    >
    > diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
    > index 7e52295..790aaa1 100644
    > --- a/drivers/acpi/acpi_pad.c
    > +++ b/drivers/acpi/acpi_pad.c
    > @@ -30,7 +30,7 @@
    > #include <acpi/acpi_bus.h>
    > #include <acpi/acpi_drivers.h>
    >
    > -#define ACPI_PROCESSOR_AGGREGATOR_CLASS "processor_aggregator"
    > +#define ACPI_PROCESSOR_AGGREGATOR_CLASS "cpu_aggregator"
    > #define ACPI_PROCESSOR_AGGREGATOR_DEVICE_NAME "Processor Aggregator"
    > #define ACPI_PROCESSOR_AGGREGATOR_NOTIFY 0x80
    > static DEFINE_MUTEX(isolated_cpus_lock);
    sorry for being later to reply. Better the name could be 'acpi_pad', which
    is what the spec called. cpu_aggregator looks like a invented name.

    Thanks,
    Shaohua


    \
     
     \ /
      Last update: 2010-04-06 03:23    [W:0.019 / U:90.864 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site