Messages in this thread |  | | | Date | Sun, 4 Apr 2010 11:58:27 +0200 | | From | Ingo Molnar <> | | Subject | Re: [PATCH 0/2] perf newt: Zoom operations |
| |
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo, > > Please consider pulling from the "perf" branch in: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 > > Best Regards, > > Arnaldo Carvalho de Melo (2): > perf newt: Add a "Zoom into foo.so DSO" and reverse operations > perf TUI: Add a "Zoom into COMM(PID) thread" and reverse operations > > tools/perf/util/newt.c | 185 ++++++++++++++++++++++++++++++++++++++++-------- > tools/perf/util/sort.h | 10 ++- > 2 files changed, 162 insertions(+), 33 deletions(-)
Pulled, thanks Arnaldo!
There's still a few basic usability glitches that i've noticed:
- it's not clear how to zoom out, once zoomed in
- there's no help screen and no help line for people to see what can be done on a given screen. While it's good that the intuitive things work by default (arrow keys, escape, enter, etc.), there should also be additional visual information about what can be done.
- i think double escape should exit, right now it stays at the 'are you sure' screen
Ingo
|  |