lkml.org 
[lkml]   [2010]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] trivial: use (C) instead of \251

* Jiri Kosina <jkosina@suse.cz> wrote:

> On Fri, 30 Apr 2010, Ingo Molnar wrote:
>
> > > > The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and
> > > > causes annoying problems with some editors and tools. Use (C)
> > > > instead.
> > > >
> > > > Signed-off-by: Tejun Heo <tj@kernel.org>
> > > > Cc: Paul Mackerras <paulus@au1.ibm.com>
> > > > ---
> > > > I'm not really sure this would survive transport over mail in
> > > > appliable form, attaching the patch too just in case.
> > >
> > > It didn't survive :) But it was easy enough to fix by hand. Applied,
> > > thanks Tejun.
> >
> > NAK.
> >
> > A similar patch was sent a few weeks ago, it was objected to and rejected -
> > the copyright character was used for legal reasons.
>
> Well, Paul himself stated that according to their lawyer department,
> "Copyright" (which is there) is enough. So it made sense to remove invalid
> (at least in some sense) character.
>
> Also zillion of other files copyrighted by Paul contain "Copyright (C)".
>
> If we really want this character there then, why not rather in UTF-8, so
> that it works flawlessly?

It might be fine but i havent seen Paul reply to this thread - and this is my
point: _you_ should have waited for an ack from Paul (who is co-maintaining
that file) before applying it. The commit doesnt have it:

commit 62006c58a9a2d8b72b5b65301965bc444d43e22c
Author: Tejun Heo <tj@kernel.org>
Date: Wed Apr 28 11:30:31 2010 +0200

trivial: use (C) instead of \251

The latin-1 copyright character \251 is invalid in ASCII or UTF-8 and
causes annoying problems with some editors and tools. Use (C)
instead.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Paul Mackerras <paulus@au1.ibm.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

We dont just go and change people's copyright notices, no matter how trivial
it may seem ...

Thanks,

Ingo


\
 
 \ /
  Last update: 2010-04-30 20:55    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site