Messages in this thread | | | Date | Thu, 29 Apr 2010 09:57:07 +0530 | From | Ananth N Mavinakayanahalli <> | Subject | Re: [PATCH -tip 2/2] [BUGFIX] kprobes/x86: Fix removed int3 checking order |
| |
On Wed, Apr 28, 2010 at 11:39:40AM -0400, Masami Hiramatsu wrote: > Ananth N Mavinakayanahalli wrote: > > On Tue, Apr 27, 2010 at 06:33:49PM -0400, Masami Hiramatsu wrote:
...
> > You may also want to fix up the comment on top of kprobe_handler() about > > the interrupt gate as its only true for x86_32 and not x86_64, right? > > Hmm, I couldn't find it, could you tell me more details? > (and maybe, it's another issue) > > what I could find is int3 handler is registered as interrupt gate > on both of x86-32/64. > > void __init trap_init(void) > { > ... > /* int3 can be called from all */ > set_system_intr_gate_ist(3, &int3, DEBUG_STACK);
Ah, never mind. I was wrong. IIRC, before the 32-64 bit merger, 64bit still used a trap gate.
Ananth
| |