lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/10][RFC] tracing: Convert TRACE_EVENT() to use the DECLARE_TRACE_DATA()
    * Steven Rostedt (rostedt@goodmis.org) wrote:
    > From: Steven Rostedt <srostedt@redhat.com>
    >
    > Switch the TRACE_EVENT() macros to use DECLARE_TRACE_DATA(). This
    > patch is done to prove that the DATA macros work. If any regressions
    > were to surface, then this patch would help a git bisect to localize
    > the area.
    >
    > Once again this patch increases the size of the kernel.
    >

    As recommended in the earlier email:

    It would make sense to just add the extra "callback_data" argument
    directly to DECLARE_TRACE(), modify the user (TRACE_EVENT) accordingly.
    And possibly create a TRACE_EVENT_NOARG() variant.

    Thanks,

    Mathieu

    > text data bss dec hex filename
    > 5788186 1337252 9351592 16477030 fb6b66 vmlinux.orig
    > 5792282 1333796 9351592 16477670 fb6de6 vmlinux.class
    > 5793448 1333780 9351592 16478820 fb7264 vmlinux.tracepoint
    > 5796926 1337748 9351592 16486266 fb8f7a vmlinux.data
    >
    > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    > ---
    > include/linux/tracepoint.h | 8 ++++----
    > 1 files changed, 4 insertions(+), 4 deletions(-)
    >
    > diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
    > index 4649bdb..c04988a 100644
    > --- a/include/linux/tracepoint.h
    > +++ b/include/linux/tracepoint.h
    > @@ -355,14 +355,14 @@ static inline void tracepoint_synchronize_unregister(void)
    >
    > #define DECLARE_EVENT_CLASS(name, proto, args, tstruct, assign, print)
    > #define DEFINE_EVENT(template, name, proto, args) \
    > - DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
    > + DECLARE_TRACE_DATA(name, PARAMS(proto), PARAMS(args))
    > #define DEFINE_EVENT_PRINT(template, name, proto, args, print) \
    > - DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
    > + DECLARE_TRACE_DATA(name, PARAMS(proto), PARAMS(args))
    >
    > #define TRACE_EVENT(name, proto, args, struct, assign, print) \
    > - DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
    > + DECLARE_TRACE_DATA(name, PARAMS(proto), PARAMS(args))
    > #define TRACE_EVENT_FN(name, proto, args, struct, \
    > assign, print, reg, unreg) \
    > - DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
    > + DECLARE_TRACE_DATA(name, PARAMS(proto), PARAMS(args))
    >
    > #endif /* ifdef TRACE_EVENT (see note above) */
    > --
    > 1.7.0
    >
    >

    --
    Mathieu Desnoyers
    Operating System Efficiency R&D Consultant
    EfficiOS Inc.
    http://www.efficios.com


    \
     
     \ /
      Last update: 2010-04-28 22:41    [W:0.031 / U:0.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site