lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[RFC PATCH 4/6] fuse: get page reference for readpages
    Acquire a page ref on pages in ->readpages() and release them when the
    read has finished. Not acquiring a reference didn't seem to cause any
    trouble since the page is locked and will not be kicked out of the
    page cache during the read.

    However the following patches will want to remove the page from the
    cache so a separate ref is needed. Making the reference in req->pages
    explicit also makes the code easier to understand.

    Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
    ---
    fs/fuse/file.c | 2 ++
    1 file changed, 2 insertions(+)

    Index: linux-2.6/fs/fuse/file.c
    ===================================================================
    --- linux-2.6.orig/fs/fuse/file.c 2010-04-28 15:50:32.000000000 +0200
    +++ linux-2.6/fs/fuse/file.c 2010-04-28 15:50:35.000000000 +0200
    @@ -536,6 +536,7 @@ static void fuse_readpages_end(struct fu
    else
    SetPageError(page);
    unlock_page(page);
    + page_cache_release(page);
    }
    if (req->ff)
    fuse_file_put(req->ff);
    @@ -589,6 +590,7 @@ static int fuse_readpages_fill(void *_da
    return PTR_ERR(req);
    }
    }
    + page_cache_get(page);
    req->pages[req->num_pages] = page;
    req->num_pages++;
    return 0;
    --


    \
     
     \ /
      Last update: 2010-04-28 18:21    [W:0.028 / U:0.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site