Messages in this thread | | | Date | Wed, 28 Apr 2010 17:59:03 +0800 | From | Cong Wang <> | Subject | Re: [v4 Patch 1/3] netpoll: add generic support for bridge and bonding devices |
| |
Dongdong Deng wrote: > > > + if (ops->ndo_netpoll_cleanup) > + ops->ndo_netpoll_cleanup(np->dev); > + np->dev->npinfo = NULL; > > I think it is good to set np->dev->npinfo to NULL even though we have > the netpoll_cleanup opt. >
This is redundant, since ->ndo_netpoll_cleanup will set it.
Thanks.
| |