lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: request_firmware API exhaust memory
    From
    On Wed, Apr 28, 2010 at 11:23 AM, Kay Sievers <kay.sievers@vrfy.org> wrote:
    > On Tue, Apr 27, 2010 at 15:34, Kay Sievers <kay.sievers@vrfy.org> wrote:
    >> On Tue, Apr 27, 2010 at 14:43, David Woodhouse <dwmw2@infradead.org> wrote:
    >>> This untested patch attempts to put the page array into the 'struct
    >>> firmware' so that we can free it from release_firmware().
    >>
    >> Looks good. Seems to work without problems and without leaking memory.
    >>
    >> Misses only the member in the struct firmware though. :)
    >
    > Thomas, any chance to test David's patch, if that solves the issues you've seen?
    >
    > Just add the missing line:
    >
    > --- a/include/linux/firmware.h
    > +++ b/include/linux/firmware.h
    > @@ -12,6 +12,7 @@
    >  struct firmware {
    >        size_t size;
    >        const u8 *data;
    > +       struct page **pages;
    >  };
    >
    >
    In progress. Will post results later today (timezone:GMT+2)

    Thanks
    Tomas
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-04-28 15:09    [W:0.021 / U:31.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site