lkml.org 
[lkml]   [2010]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: HID: expand hid-topseed driver to support BTC "Emprex 3009URF III Vista MCE Remote"
On Wed, 28 Apr 2010, Wayne Thomas wrote:

> >> OK, next attempt...
> >
> > The patch is OK, but your mail client whitespace-damaged it. Could you
> > please fix up your client and resend? (or attach it separately as an
> > attachment, if your client can't be fixed).
> >
> > Thanks,
>
> I thought it might have; sorry about that.
> Have attached patch as separate file as a precaution.

Thanks for the patch.

What is the reason for it being backwards-compatible with the older
topspeed device?

Changes such as

- case 0x048: ts_map_key_clear(KEY_RED); break;
+ case 0x05b: ts_map_key_clear(KEY_RED); break;

(and no other handling of neither 0x048 nor KEY_RED) make me wonder ...

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.


\
 
 \ /
  Last update: 2010-04-28 13:53    [W:0.058 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site