lkml.org 
[lkml]   [2010]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] drivers/staging/dt3155: Integrate 3 badly styled files into 1 clean file
    On Mon, Mar 29, 2010 at 12:34:28AM -0700, Joe Perches wrote:
    > Make variables static where appropriate
    > Rename dt3155_<foo_with_long_names> variables to dt_<foo_tla>
    > to reduce code length and make more lines fit well in 80 chars
    > Remove now unnecessary .h files
    > Change indent to use tabs
    > Remove unused functions
    > Used bool more often
    > Checkpatch clean

    This is too much in one patch, sorry. It also doesn't apply due to
    other changes in these files (that you then remove in patch 3) from
    other developers.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2010-04-28 01:11    [W:0.021 / U:1.416 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site