lkml.org 
[lkml]   [2010]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC: linux-next 1/2] irq: Add CPU mask affinity hint callback framework
    On Sun, 18 Apr 2010, Peter P Waskiewicz Jr wrote:
    > +/**
    > + * struct irqaffinityhint - per interrupt affinity helper
    > + * @callback: device driver callback function
    > + * @dev: reference for the affected device
    > + * @irq: interrupt number
    > + */
    > +struct irqaffinityhint {
    > + irq_affinity_hint_t callback;
    > + void *dev;
    > + int irq;
    > +};

    Why do you need that extra data structure ? The device and the irq
    number are known, so all you need is the callback itself. So no need
    for allocating memory ....

    > +static ssize_t irq_affinity_hint_proc_write(struct file *file,
    > + const char __user *buffer, size_t count, loff_t *pos)
    > +{
    > + /* affinity_hint is read-only from proc */
    > + return -EOPNOTSUPP;
    > +}
    > +

    Why do you want a write function when the file is read only ?

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2010-04-27 14:35    [W:0.020 / U:392.584 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site