lkml.org 
[lkml]   [2010]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[RFC PATCH v2] nohz/sched: disable ilb on !mc_capable()
From: Dominik Brodowski <linux@dominikbrodowski.net>
Date: Thu, 8 Apr 2010 21:51:18 +0200
Subject: [PATCH] nohz/sched: disable ilb on !mc_capable()

On my dual-core, !mc_capbale() CPU, the idle load balancer (ilb) is one
of the main reasons ticks are not stopped: Under moderate load (~98 % idle),
upt o half of the calls to tick_nohz_top_sched_tick() are aborted due
to calls to select_nohz_load_balancer(1).

I suspect this is caused by the following phenomenon:

CPU0 CPU1
<active> <active>
tick_nohz_stop_sched_tick(1)
select_nohz_load_balancer(1)
=> CPU0 becomes ilb owner, <CPU1 becomes idle a bit later>
tick is not stopped, tick_nohz_stop_sched_tick(1)
CPU0 goes to sleep for => CPU1 isn't the ilb owner,
exactly 1 tick. tick is stopped.
<short sleep> <long sleep>
---> scheduler_tick()
tick_nohz_stop_sched_tick(0)
tick_nohz_stop_sched_tick(1)
=> is ilb owner, all CPUs are
idle, CPU0 may go to sleep.

If all CPU cores have hardly anything to do, letting the active CPU do
idle load balancing allows us to enter deep sleep states earlier, and for
longer periods of time. Furthermore, on !mc_capable() systems, it seems that
the ilb algorithm isn't needed at all. Let's show this for a 2-core system:

- if both cores are active, ilb is deactivated
- if no core is active, ilb is deactivated
- if only one core is active, it attempts to balance its load off to other
CPUs on each tick anyway. ilb wouldn't act quicker.

This patch decreases the amount of wakeups on my completely idle notebook by
about two thirds.

Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>

diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 5a5ea2c..8ad8a03 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -3290,6 +3290,9 @@ int select_nohz_load_balancer(int stop_tick)
if (stop_tick) {
cpu_rq(cpu)->in_nohz_recently = 1;

+ if (!mc_capable())
+ return 0;
+
if (!cpu_active(cpu)) {
if (atomic_read(&nohz.load_balancer) != cpu)
return 0;
@@ -3339,6 +3342,9 @@ int select_nohz_load_balancer(int stop_tick)
if (!cpumask_test_cpu(cpu, nohz.cpu_mask))
return 0;

+ if (!mc_capable())
+ return 0;
+
cpumask_clear_cpu(cpu, nohz.cpu_mask);

if (atomic_read(&nohz.load_balancer) == cpu)

\
 
 \ /
  Last update: 2010-04-26 22:33    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site