Messages in this thread | | | Date | Mon, 26 Apr 2010 13:40:08 -0600 | From | Jonathan Corbet <> | Subject | Re: [PATCH 10/11] viafb: rework the I2C support in the VIA framebuffer driver |
| |
On Sun, 25 Apr 2010 17:56:09 +0200 Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:
> + if (viafb_lvds_identify_vt1636(VIA_I2C_ADAP_26)) { > which should rather be > - viaparinfo->shared->i2c_stuff.i2c_port = GPIOPORTINDEX; > - if (viafb_lvds_identify_vt1636()) { > + if (viafb_lvds_identify_vt1636(VIA_I2C_ADAP_2C)) { > after which your patches including this work fine (on VX800 and CLE266).
Two bugs, actually...I wouldn't expect things to work with the wrong port, but neither should it crash. The crash is fixed in the second series (where I added checks to ensure that the adapter was active) so I'll probably leave it as-is in between. The port number needs to be fixed, though, thanks for catching that.
jon
| |