lkml.org 
[lkml]   [2010]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 07/11] staging: cyrstalhd: clean up crystalhd_user_close() return code
    Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
    ---
    drivers/staging/crystalhd/crystalhd_cmds.c | 6 ++----
    drivers/staging/crystalhd/crystalhd_cmds.h | 2 +-
    2 files changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c
    index bfa11df..d341876 100644
    --- a/drivers/staging/crystalhd/crystalhd_cmds.c
    +++ b/drivers/staging/crystalhd/crystalhd_cmds.c
    @@ -913,7 +913,7 @@ BC_STATUS crystalhd_user_open(struct crystalhd_cmd *ctx,
    * Closer aplication handle and release app specific
    * resources.
    */
    -BC_STATUS crystalhd_user_close(struct crystalhd_cmd *ctx, struct crystalhd_user *uc)
    +void crystalhd_user_close(struct crystalhd_cmd *ctx, struct crystalhd_user *uc)
    {
    uint32_t mode = uc->mode;

    @@ -928,14 +928,12 @@ BC_STATUS crystalhd_user_close(struct crystalhd_cmd *ctx, struct crystalhd_user
    crystalhd_hw_free_dma_rings(&ctx->hw_ctx);
    crystalhd_destroy_dio_pool(ctx->adp);
    } else if (bc_cproc_get_user_count(ctx)) {
    - return BC_STS_SUCCESS;
    + return;
    }

    crystalhd_hw_close(&ctx->hw_ctx);

    ctx->state = BC_LINK_INVALID;
    -
    - return BC_STS_SUCCESS;
    }

    /**
    diff --git a/drivers/staging/crystalhd/crystalhd_cmds.h b/drivers/staging/crystalhd/crystalhd_cmds.h
    index ea1b0d4..026a07e 100644
    --- a/drivers/staging/crystalhd/crystalhd_cmds.h
    +++ b/drivers/staging/crystalhd/crystalhd_cmds.h
    @@ -80,7 +80,7 @@ BC_STATUS crystalhd_resume(struct crystalhd_cmd *ctx);
    crystalhd_cmd_proc crystalhd_get_cmd_proc(struct crystalhd_cmd *ctx, uint32_t cmd,
    struct crystalhd_user *uc);
    BC_STATUS crystalhd_user_open(struct crystalhd_cmd *ctx, struct crystalhd_user **user_ctx);
    -BC_STATUS crystalhd_user_close(struct crystalhd_cmd *ctx, struct crystalhd_user *uc);
    +void crystalhd_user_close(struct crystalhd_cmd *ctx, struct crystalhd_user *uc);
    int crystalhd_setup_cmd_context(struct crystalhd_cmd *ctx, struct crystalhd_adp *adp);
    void crystalhd_delete_cmd_context(struct crystalhd_cmd *ctx);
    bool crystalhd_cmd_interrupt(struct crystalhd_cmd *ctx);
    --
    1.7.1


    \
     
     \ /
      Last update: 2010-04-25 15:47    [W:0.022 / U:179.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site