Messages in this thread | | | Date | Sat, 24 Apr 2010 11:12:12 +0200 | From | Stefan Richter <> | Subject | Re: [PATCH 1/3] Documentation: -stable rules: upstream commit ID requirement reworded |
| |
tytso@mit.edu wrote: > On Thu, Apr 22, 2010 at 03:40:14PM -0700, Greg Kroah-Hartman wrote: >> From: Stefan Richter <stefanr@s5r6.in-berlin.de> >> >> It is a hard requirement to include the upstream commit ID in the >> changelog of a -stable submission, not just a courtesy to the stable >> team. This concerns only mail submission though, which is no longer >> the only way into stable. (Also, fix a double "the".) > > I find the upstream commit ID to be highly useful when looking at > commits in the stable tree. So it would be nice IMHO if we could > enforce this requirement regardless of whether the submission path is > via e-mail or git.
In the semi-automatic submission path via git --- i.e. of commits which feature a Cc: stable@kernel.org line in the changelog when they show up in Linus' tree --- the upstream commit ID is not known to the submitter at the time of submission. Apparently Greg's scripts modify the changelogs respectively when he cherry-picks from linux-2.6.git, so the requirement is also always fulfilled with this alternative submission path.
E.g. as in http://lkml.org/lkml/2010/4/22/294 which was apparently submitted the semi-automatic way, via http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=44fef22416886a04d432043f741a6faf2c6ffefd -- Stefan Richter -=====-==-=- -=-- ==--- http://arcgraph.de/sr/
| |