lkml.org 
[lkml]   [2010]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/6] hw-breakpoints: Change/Enforce some breakpoints policies
    On Fri, Apr 23, 2010 at 07:13:56AM +0200, Frederic Weisbecker wrote:
    > diff --git a/arch/sh/include/asm/hw_breakpoint.h b/arch/sh/include/asm/hw_breakpoint.h
    > index 965dd78..c575cf5 100644
    > --- a/arch/sh/include/asm/hw_breakpoint.h
    > +++ b/arch/sh/include/asm/hw_breakpoint.h
    > @@ -47,7 +47,8 @@ struct pmu;
    > #define HBP_NUM 2
    >
    > /* arch/sh/kernel/hw_breakpoint.c */
    > -extern int arch_check_va_in_userspace(unsigned long va, u16 hbp_len);
    > +extern int arch_check_bp_in_kernelspace(struct perf_event *bp);
    > +extern int arch_validate_hwbkpt_settings(struct perf_event *bp);
    > extern int arch_validate_hwbkpt_settings(struct perf_event *bp,
    > struct task_struct *tsk);
    > extern int hw_breakpoint_exceptions_notify(struct notifier_block *unused,

    You forgot to kill off the existing arch_validate_hwbkpt_settings()
    definition, so this part at least breaks the build.


    \
     
     \ /
      Last update: 2010-04-23 10:41    [W:0.021 / U:118.960 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site