lkml.org 
[lkml]   [2010]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUGFIX][PATCH] memcg rcu lock fix v3
On Fri, 23 Apr 2010 12:30:11 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:

> * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2010-04-23 13:03:49]:
>
> > On Fri, 23 Apr 2010 12:58:14 +0900
> > KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> >
> > > On Fri, 23 Apr 2010 11:55:16 +0800
> > > Li Zefan <lizf@cn.fujitsu.com> wrote:
> > >
> > > > Li Zefan wrote:
> > > > > KAMEZAWA Hiroyuki wrote:
> > > > >> On Fri, 23 Apr 2010 11:00:41 +0800
> > > > >> Li Zefan <lizf@cn.fujitsu.com> wrote:
> > > > >>
> > > > >>> with CONFIG_PROVE_RCU=y, I saw this warning, it's because
> > > > >>> css_id() is not under rcu_read_lock().
> > > > >>>
> > > > >> Ok. Thank you for reporting.
> > > > >> This is ok ?
> > > > >
> > > > > Yes, and I did some more simple tests on memcg, no more warning
> > > > > showed up.
> > > > >
> > > >
> > > > oops, after trigging oom, I saw 2 more warnings:
> > > >
> > >
> > > Thank you for good testing.
> > v3 here...sorry too rapid posting...
> >
>
> Looking at the patch we seem to be protecting the use of only css_*().
> I wonder if we should push down the rcu_read_*lock() semnatics to the
> css routines or is it just too instrusive to do it that way?
>

Maybe worth to consider for future patches for clean up.

Thanks,
-Kame




\
 
 \ /
  Last update: 2010-04-23 09:05    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site