Messages in this thread | | | Date | Fri, 23 Apr 2010 20:20:59 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH 1/2] Make WMI be selected automatically when needed |
| |
On Sat, Apr 17, 2010 at 02:58:29AM +0200, Éric Piel wrote:
> config LEDS_DELL_NETBOOKS > tristate "External LED on Dell Business Netbooks" > - depends on X86 && ACPI_WMI > + depends on X86 > + depends on ACPI > + select ACPI_WMI
I dislike this. The originally stated dependencies are correct and more accurately represent what the code requires, and changing that for the sake of making it easier for people to find the driver sounds like it's trying to cover up shortcomings in our configuration system more than anything else.
-- Matthew Garrett | mjg59@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |