Messages in this thread | | | Date | Fri, 23 Apr 2010 11:06:15 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH -v2 0/5] AMD L3 cache index disable fixes for .35 |
| |
On 04/23/2010 07:09 AM, Borislav Petkov wrote: > > Ok, looking at the k8.o object it is 507 bytes so I don't think > compiling it in would hurt embedded people too much: > > text data bss dec hex filename > 379 104 24 507 1fb arch/x86/kernel/k8.o > > So how about the following? It should apply cleanly on top and it > survived a bunch of randconfigs here so far. >
I have to say I think that's pretty ridiculous for someone who cares so much about size that they have disabled CONFIG_PCI that they can just add another half-kilobyte of code that is going to do absolutely nothing. Think about the kind of x86 CPUs that could even consider disabling CONFIG_PCI -- we're talking pretty deep embedded by now.
So, no, I don't think this is an option. Force-enabling CONFIG_PCI on x86 would be a more realistic option, and I honestly don't know how many people would object to that, but not right now.
The obvious answer instead is to augment the list of stubs in <asm/k8.h>. In particular, move num_k8_northbridges into the #ifdef and just #define num_k8_northbridges 0 in the other clause.
-hpa
| |