lkml.org 
[lkml]   [2010]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] gpio: max732x: fix input configuration for open-drain pins
    Date
    From
    On Tue, 20 Apr 2010 16:51:48 -0700, Andrew Morton
    <akpm@linux-foundation.org> wrote:
    >> On Tue, 16 Mar 2010 10:19:00 +0100
    >
    > I bet you thought I'd forgotten.

    Naaaah... I trust your memory more than mine... ;-)

    > You really did mean `&' here, but one very much expects a variable
    > called is_foo to be a boolean, and booleans want `&&'.

    Actually, the attached patch is a much simpler solution to this particular
    one. We already checked that the pin is input-capable. Use the same mask to
    check that the pin is also output-capable, and thus open-drain. No need for
    an additional variable.

    Thanks,

    M.
    --
    Who you jivin' with that Cosmik Debris?
    \
     
     \ /
      Last update: 2010-04-23 15:39    [W:0.022 / U:0.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site