lkml.org 
[lkml]   [2010]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[015/139] x86,kgdb: Always initialize the hw breakpoint attribute
    2.6.33-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Jason Wessel <jason.wessel@windriver.com>

    commit ab310b5edb8b601bcb02491ed6f7676da4fd1757 upstream.

    It is required to call hw_breakpoint_init() on an attr before using it
    in any other calls. This fixes the problem where kgdb will sometimes
    fail to initialize on x86_64.

    Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    LKML-Reference: <1269975907-27602-1-git-send-email-jason.wessel@windriver.com>
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/x86/kernel/kgdb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/kernel/kgdb.c
    +++ b/arch/x86/kernel/kgdb.c
    @@ -618,8 +618,8 @@ int kgdb_arch_init(void)
    * portion of kgdb because this operation requires mutexs to
    * complete.
    */
    + hw_breakpoint_init(&attr);
    attr.bp_addr = (unsigned long)kgdb_arch_init;
    - attr.type = PERF_TYPE_BREAKPOINT;
    attr.bp_len = HW_BREAKPOINT_LEN_1;
    attr.bp_type = HW_BREAKPOINT_W;
    attr.disabled = 1;



    \
     
     \ /
      Last update: 2010-04-22 22:33    [W:0.021 / U:30.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site