lkml.org 
[lkml]   [2010]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[044/139] ath9k: fix double calls to ath_radio_enable
    2.6.33-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Felix Fietkau <nbd@openwrt.org>

    commit 1144601118507f8b3b676a9a392584d216d3f2cc upstream.

    With the enable_radio being uninitialized, ath_radio_enable() might be
    called twice, which can leave some hardware in an undefined state.

    Signed-off-by: Felix Fietkau <nbd@openwrt.org>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/wireless/ath/ath9k/main.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/net/wireless/ath/ath9k/main.c
    +++ b/drivers/net/wireless/ath/ath9k/main.c
    @@ -2721,8 +2721,7 @@ static int ath9k_config(struct ieee80211
    all_wiphys_idle = ath9k_all_wiphys_idle(sc);
    ath9k_set_wiphy_idle(aphy, idle);

    - if (!idle && all_wiphys_idle)
    - enable_radio = true;
    + enable_radio = (!idle && all_wiphys_idle);

    /*
    * After we unlock here its possible another wiphy



    \
     
     \ /
      Last update: 2010-04-22 22:27    [W:0.032 / U:0.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site