lkml.org 
[lkml]   [2010]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mac8390: change an error return code and some cleanup, take 3
From
From: Finn Thain <fthain@telegraphics.com.au>
Date: Sat, 17 Apr 2010 13:16:04 +1000 (EST)

>
> Change an error return code from -EAGAIN to -EBUSY since the former is
> misleading.
>
> Nubus slots are geographically addressed and their irqs are equally
> inflexible. -EAGAIN is misleading because retrying will not help fix
> whatever bug it was that made the irq unavailable.

request_irq() itself returns an appropriate error code, so the
correct change is to do:

err = request_irq( ... );
if (err) {
...
and return 'err'.


\
 
 \ /
  Last update: 2010-04-22 01:33    [from the cache]
©2003-2011 Jasper Spaans