lkml.org 
[lkml]   [2010]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 2/2] ibft: For UEFI machines actually do scan ACPI for iBFT.
    On Fri,  9 Apr 2010 14:21:28 +0000
    Konrad Rzeszutek Wilk <konrad@kernel.org> wrote:

    > For machines with IBFT 1.03 do scan the ACPI table for 'iBFT'
    > or for 'IBFT'. If the machine is in UEFI mode, only do the ACPI
    > table scan. For all other machines (pre IBFT 1.03) do
    > a memory scan if not found in the ACPI tables.
    >
    > Author: Konrad Rzeszutek Wilk <konrad@kernel.org>

    The Author: line is unneeded and inappropriate here. That's what the
    From: line does.

    > Acked-by: Peter Jones <pjones@redhat.com>
    > Tested-by: Mike Christie <michaelc@cs.wisc.edu>
    > Signed-off-by: Konrad Rzeszutek Wilk <konrad@kernel.org>

    Your covering email indicates that Mike and Peter wrote the patches,
    but neither of the patches have their signoffs. Can we please sort all
    this out?


    > ---
    > drivers/firmware/iscsi_ibft_find.c | 31 +++++++++++++++++++------------
    > 1 files changed, 19 insertions(+), 12 deletions(-)
    >
    > diff --git a/drivers/firmware/iscsi_ibft_find.c b/drivers/firmware/iscsi_ibft_find.c
    > index 8f4d157..0bc3fae 100644
    > --- a/drivers/firmware/iscsi_ibft_find.c
    > +++ b/drivers/firmware/iscsi_ibft_find.c
    > @@ -56,23 +56,12 @@ static int __init acpi_find_ibft(struct acpi_table_header *header)
    > }
    > #endif /* CONFIG_ACPI */
    >
    > -/*
    > - * Routine used to find the iSCSI Boot Format Table. The logical
    > - * kernel address is set in the ibft_addr global variable.
    > - */
    > -unsigned long __init find_ibft_region(unsigned long *sizep)
    > +static int __init find_ibft_mem_scan(void)

    The name seems weird. find_foo_scan(). So we're trying to find a scan
    for a foo.

    > {
    > unsigned long pos;
    > unsigned int len = 0;
    > void *virt;
    >
    > - ibft_addr = NULL;
    > -
    > - /* iBFT 1.03 section 1.4.3.1 mandates that UEFI machines will
    > - * only use ACPI for this */
    > - if (efi_enabled)
    > - return 0;
    > -
    > for (pos = IBFT_START; pos < IBFT_END; pos += 16) {
    > /* The table can't be inside the VGA BIOS reserved space,
    > * so skip that area */
    >
    > ...
    >


    \
     
     \ /
      Last update: 2010-04-21 23:33    [W:0.026 / U:34.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site